Updated digital post handler #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jekuaitk
force-pushed
the
feature/os2web_key_digital_post
branch
from
2182f4f to
1964c27
Compare
jekuaitk
force-pushed
the
feature/os2web_key_digital_post
branch
2 times, most recently
from
083b926 to
a30a0cb
Compare
jekuaitk
force-pushed
the
feature/os2web_key_digital_post
branch
from
a30a0cb to
b0b898d
Compare
rimi-itk
reviewed
Jan 24, 2025
Comment on lines
19
to
20
| $elementInfoManager: "@plugin.manager.element_info" | ||
| $webformTokenManager: "@webform.token_manager" |
There was a problem hiding this comment.
Are these really needed? Can we use
function __construct(
…
#[\Symfony\Component\DependencyInjection\Attribute\Autowire]
$elementInfoManager,
…
)
instead? Using an attribute may make the code easier to maintain.
Author
There was a problem hiding this comment.
Makes sense. phpcs will deem this a possible useless override so i have ignored this specific sniff in the constructor.
modules/os2forms_digital_post/src/Drush/Commands/DigitalPostTestCommands.php
Show resolved
Hide resolved
modules/os2forms_digital_post/src/Helper/CertificateLocatorHelper.php
Outdated
Show resolved
Hide resolved
rimi-itk
reviewed
Jan 27, 2025
| /** | ||
| * {@inheritDoc} | ||
| */ | ||
| // phpcs:disable Generic.CodeAnalysis.UselessOverridingMethod |
There was a problem hiding this comment.
Why don't you add the attributes in AbstractMessageHelper?
jekuaitk
force-pushed
the
feature/os2web_key_digital_post
branch
from
1c0337b to
c0c053e
Compare
rimi-itk
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://leantime.itkdev.dk/#/tickets/showTicket/2726